Skip to content

Fix leaks with multiple calls to DatePeriod iterator current() #18624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: PHP-8.3
Choose a base branch
from
Open

Fix leaks with multiple calls to DatePeriod iterator current() #18624

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented May 22, 2025 •
edited
Loading

Destroy the old value first. We can't skip recreating the value because
the object may have been changed in between calls.

@nielsdos nielsdos requested a review from derickr as a code owner May 22, 2025 21:07
@nielsdos nielsdos force-pushed the date-iter-leak-1 branch from 0a2ffc0 to 36ee083 Compare May 23, 2025 16:42
@nielsdos
Fix leaks with multiple calls to DatePeriod iterator current()
f322f4a 
Destroy the old value first. We can't skip recreating the value because
the object may have been changed in between calls.
@nielsdos nielsdos force-pushed the date-iter-leak-1 branch from 36ee083 to f322f4a Compare May 23, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees
No one assigned
Labels
Extension: date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nielsdos